NodeInfo broadcast ensure default on 0 and enforce 1 hour minimum #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
changed the title
GUVWAF
approved these changes
Mar 15, 2024
Does anybody actually use this? if it was for me we can throw it out completely. Also the module presets in source comments... |
|
I do not. I've maybe used it once in the past 3 years. I suspect Kevin used it a lot in earlier development of the project.
|
upchui
added a commit
to upchui/firmware-Meshtastic-Unleashed
that referenced
this pull request
Mar 16, 2024
* (1/3) Support L76B GNSS chip found on pico waveshare shield. Original work by @Mictronics * NodeInfo broadcast ensure default on 0 and enforce 1 hour minimum (meshtastic#3415) * NodeInfo broadcasts ensure defaults on 0 and enforce 1 hour minumum * Doh! * Hey that's not on config! * We don't use Lorawan (meshtastic#3417) #warning "Persistent storage not supported!" [-Wcpp] * [create-pull-request] automated change (meshtastic#3418) Co-authored-by: thebentern <[email protected]> * fix compilation * don't fix this to a hardware model. * new Accelerometer lib (meshtastic#3413) * new Accelerometer lib * Use our fork till upstreasm merges changes. * that PR escalated quickly * resurrect display flip * that should work now * (2/3) Add Slow Clock Support for RP2040 platform. This will disable USB Softserial. * More comprehensive client proxy queue guards (meshtastic#3414) * More comprehensive MQTT thread and queue guards * Consolidate logic * Remove channel check * Check for map_reporting_enabled as well * Update message * Remove channel check from here as well * One liner * Start the mqtt thread back up when channels change and we want mqtt * fix for I2C scan getting stuck (meshtastic#3375) * refactor: add delay for T-Echo peripherals setup * comment out `PIN_POWER_EN1` * [create-pull-request] automated change (meshtastic#3419) Co-authored-by: thebentern <[email protected]> * Handle for heartbeat toradio packets (meshtastic#3420) * Factory reset GNSS_MODEL_MTK GPS modules with PCAS10,3 (meshtastic#3388) Co-authored-by: Ben Meadors <[email protected]> * [create-pull-request] automated change (meshtastic#3422) Co-authored-by: thebentern <[email protected]> * (3/3) Add variant for pico with waveshare and GPS hat (meshtastic#3412) * (3/3) Add variant for pico with waveshare and GPS hat, utilizing slow clock. * Not everybody has Serial2 * Trunk * Push it real gud * No init --------- Co-authored-by: Ben Meadors <[email protected]> --------- Co-authored-by: Thomas Göttgens <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: thebentern <[email protected]> Co-authored-by: Andre K <[email protected]> Co-authored-by: David Ellefsen <[email protected]>
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/settings-for-driving-around-to-find-other-nodes/7525/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #transport-layer room.
Also removed some of the no_save cruft that's been an eye-sore.